Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC e2e test is consistently failing #606

Closed
sebastienvas opened this issue Aug 27, 2017 · 9 comments
Closed

RBAC e2e test is consistently failing #606

sebastienvas opened this issue Aug 27, 2017 · 9 comments
Assignees
Milestone

Comments

@sebastienvas
Copy link
Contributor

The current rbac-no-auth e2e test is currently failing % of the time.

After looking at the logs, the failure seems to be consistenly the mixer test and that the metrics are not being propagated
mixer_test.go:212: Could not find value: value not found for map[string]string{}
mixer_test.go:216: Bad metric value: got 0.000000, want at least 1.000000

@sebastienvas sebastienvas added this to the Istio 0.2 milestone Aug 27, 2017
@sebastienvas sebastienvas changed the title RBAC e2e test is failing RBAC e2e test is flaky Aug 27, 2017
@sebastienvas
Copy link
Contributor Author

@Brian-Xincheng-Zhang, please find someone to work on this.

@wattli
Copy link
Contributor

wattli commented Aug 30, 2017

I don't think it is not auth related. assign back to @Brian-Xincheng-Zhang , please try mixer guys.

@Brian-Xincheng-Zhang
Copy link
Contributor

Brian-Xincheng-Zhang commented Aug 30, 2017

I had a chat with Mandar.

  1. mixer config server will be gone next week. so let's wait until next week to see whether the problem persists.
  2. the issue happens when a config is being pushed to mixer, and it happens to two PRs. the flakiness could be caused by both code and test-infra. therefore, if the problem persists next week, Mandar and engprod oncall will work together to debug the issue.
    I will reassign the bug to Mandar and next week's EngProd oncall.

@yutongz
Copy link
Contributor

yutongz commented Aug 31, 2017

We have a EngProd oncall now? @sebastienvas

@Brian-Xincheng-Zhang
Copy link
Contributor

Brian-Xincheng-Zhang commented Aug 31, 2017 via email

@sebastienvas
Copy link
Contributor Author

This impacts release 0.2.1

@ldemailly ldemailly changed the title RBAC e2e test is flaky RBAC e2e test is consistently failing Sep 4, 2017
@ldemailly
Copy link
Contributor

it's failing all the time, we need to make it pass again and then make it mandatory so it stays passing

ps: right now though nothing seems to pass, even non rbac see #653 for one of the causes

@yutongz
Copy link
Contributor

yutongz commented Sep 12, 2017

Fixed

@ldemailly
Copy link
Contributor

fixed in #711

kyessenov pushed a commit to kyessenov/istio that referenced this issue Aug 13, 2018
Automatic merge from submit-queue

[DO NOT MERGE] Auto PR to update dependencies of proxy

This PR will be merged automatically once checks are successful.
```release-note
none
```
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
* Add the istiod SA and Cluster binding.

Using kubect apply -k ...cluster will support both istio and istiod in
same cluster.

* Initial yaml for istiod.

For now kustomize only - no need for helm ( we may add a small helm
wrapper later)

* Initial merging of istiod enablement

* Remove old istiod

* Fix name

* Forgot to add 2 files

* Add the settings for SDS/secure token

* Fix knative test

* Fix the prow kind

* Added few comments and remove one more 'values' for istiod
0x01001011 pushed a commit to thedemodrive/istio that referenced this issue Jul 16, 2020
* grpc adapter connection auth.

* proto.lock.
incfly pushed a commit to incfly/istio that referenced this issue Mar 25, 2022
* use 1.17 for istio 1.11 and 1.12

* bump regular go version too

* backport changes from `Istio 1.12` that fix e2e tests on `Go 1.17`

Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io>

Co-authored-by: Yaroslav Skopets <yaroslav@tetrate.io>
luksa pushed a commit to luksa/istio that referenced this issue Sep 29, 2022
…tio#606)

* OSSM-742 Improve Maistra container images build (istio#534)

* OSSM-742 Improve Maistra container images build

* Simplify make rules and Dockerfiles

* Fix dockerfiles lint issues

* Reorganize files and apply image naming convention

* Update MAISTRA_VERSION and ISTIO_VERSION

* Adapt images builds relying on upstream build tool

* Add copyright and license into scripts
luksa pushed a commit to luksa/istio that referenced this issue Apr 11, 2024
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (istio#606)

* OSSM-742 Improve Maistra container images build (istio#534)

* OSSM-742 Improve Maistra container images build

* Simplify make rules and Dockerfiles

* Fix dockerfiles lint issues

* Reorganize files and apply image naming convention

* Update MAISTRA_VERSION and ISTIO_VERSION

* Adapt images builds relying on upstream build tool

* Add copyright and license into scripts

* chore: updates image labels to reflect actual targeted versions

* chore: removes vendor left-overs

Co-authored-by: bmangoen <bmangoen@gmail.com>
dgn pushed a commit to dgn/istio that referenced this issue Jun 13, 2024
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (istio#606)

* OSSM-742 Improve Maistra container images build (istio#534)

* OSSM-742 Improve Maistra container images build

* Simplify make rules and Dockerfiles

* Fix dockerfiles lint issues

* Reorganize files and apply image naming convention

* Update MAISTRA_VERSION and ISTIO_VERSION

* Adapt images builds relying on upstream build tool

* Add copyright and license into scripts

* chore: updates image labels to reflect actual targeted versions

* chore: removes vendor left-overs

Co-authored-by: bmangoen <bmangoen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants