Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install template for sidecar initializer #636

Closed
gyliu513 opened this issue Sep 1, 2017 · 4 comments
Closed

Add install template for sidecar initializer #636

gyliu513 opened this issue Sep 1, 2017 · 4 comments
Assignees

Comments

@gyliu513
Copy link
Member

gyliu513 commented Sep 1, 2017

We introduced sidecar initializer at istio/old_pilot_repo#335 , should enable it as a deployment here.

/cc @ayj comments?

@gyliu513 gyliu513 self-assigned this Sep 1, 2017
@ayj
Copy link
Contributor

ayj commented Sep 1, 2017

Yes, that's the plan. It needs to be done in two steps: (1) enable initializer deployment (w/ConfigMap) and (2) enable InitializerConfiguration. (1) needs to be running in all test instances across the shared clusters before (2) to avoid namespaces without a corresponding initializer.

@gyliu513
Copy link
Member Author

gyliu513 commented Sep 2, 2017

@ayj for this issue, I think that I only need to add (1) a new deployment file for initializer and (2) a InitializerConfiguration , which test shall I run in istio?

@ayj
Copy link
Contributor

ayj commented Sep 5, 2017

https://github.com/istio/istio/blob/master/tests/e2e.sh

Don't enable the InitializerConfiguration by default in the changes pushed to Github just yet. Its fine to test locally but we need to phase-in this feature to avoid breaking tests in the shared cluster.

@andraxylia
Copy link
Contributor

This is done.

mandarjog pushed a commit to mandarjog/istio that referenced this issue Oct 30, 2017
Former-commit-id: ef7bf7347fa63e241561125aa129e1f2601a53fc
mandarjog pushed a commit that referenced this issue Oct 31, 2017
Former-commit-id: 0d770980faa06dc99ae8df939c25732263fdd2a3
mandarjog pushed a commit that referenced this issue Oct 31, 2017
* make it build

* Update config proto for destination policy

* Update discovery.go
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
luksa pushed a commit to luksa/istio that referenced this issue Oct 7, 2022
…ateIPs` same IP (istio#40165) (istio#636)

* Add integration tests for DNS AUTO ALLOCATION

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Reuse the same ip for services with the identical hostname

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Revert "Add integration tests for DNS AUTO ALLOCATION"

This reverts commit 61c49a5.

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Update tests

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Reuse set ip logic

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Add a release note

Signed-off-by: Yann Liu <yannliu@redhat.com>

Signed-off-by: Yann Liu <yannliu@redhat.com>

Signed-off-by: Yann Liu <yannliu@redhat.com>
Co-authored-by: Yang Liu <yann.l.80s@gmail.com>
luksa pushed a commit to luksa/istio that referenced this issue Dec 21, 2022
…ateIPs` same IP (istio#40165) (istio#636) (istio#640)

* Add integration tests for DNS AUTO ALLOCATION

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Reuse the same ip for services with the identical hostname

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Revert "Add integration tests for DNS AUTO ALLOCATION"

This reverts commit 61c49a5.

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Update tests

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Reuse set ip logic

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Add a release note

Signed-off-by: Yann Liu <yannliu@redhat.com>

Signed-off-by: Yann Liu <yannliu@redhat.com>

Signed-off-by: Yann Liu <yannliu@redhat.com>
Co-authored-by: Yang Liu <yann.l.80s@gmail.com>

Signed-off-by: Yann Liu <yannliu@redhat.com>
Co-authored-by: Yang Liu <yann.l.80s@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants