Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how to run tests/e2e.sh on minikube (ie -use_local_cluster) #645

Closed
andraxylia opened this issue Sep 2, 2017 · 3 comments
Closed

Comments

@andraxylia
Copy link
Contributor

andraxylia commented Sep 2, 2017

Right now, the tests setup ingress as type LoadBalancer and check for an external IP address to be assigned.
This does not work on minikube, so it should be removed or adapter.

We need to run and debug the e2e smoke test outside of the test cluster.

@andraxylia andraxylia added this to the Istio 0.3 milestone Sep 2, 2017
@ldemailly
Copy link
Contributor

is that with -use_local_cluster ?

@andraxylia
Copy link
Contributor Author

Cool, that works. In that case, the option -use_local_cluster needs to be documented in README, with some explanation about what it does related to ingress svc type.

@ldemailly ldemailly changed the title tests/e2e.sh should run on minikube as well document how to run tests/e2e.sh on minikube (ie -use_local_cluster) Sep 2, 2017
@ldemailly
Copy link
Contributor

yes I mentioned in some code review when I saw it that it wasn't clear what it meant etc
(in a way this is a sub task of #593 )

@sebastienvas sebastienvas removed their assignment Sep 5, 2017
mandarjog pushed a commit to mandarjog/istio that referenced this issue Oct 30, 2017
Add cache for the expression evaluation.

Instead of creating a parsed tree during every request for every expression, we are now caching the parsed expression to speedup the request serving time. During eval of an expression for a given attributes, we now just look for the express tree in the cache and evaluate it for the provided attribute bag. The size of the cache is default to 1024 entries, but it can be set during server init.

This change also includes a rename of 'Validator' interface to 'TypeChecker' and 'TypeCheck' method to 'EvalType'

Former-commit-id: af01cb5dba1305589bc03be15cdd5ea08fe71ca3
mandarjog pushed a commit that referenced this issue Oct 31, 2017
Add cache for the expression evaluation.

Instead of creating a parsed tree during every request for every expression, we are now caching the parsed expression to speedup the request serving time. During eval of an expression for a given attributes, we now just look for the express tree in the cache and evaluate it for the provided attribute bag. The size of the cache is default to 1024 entries, but it can be set during server init.

This change also includes a rename of 'Validator' interface to 'TypeChecker' and 'TypeCheck' method to 'EvalType'

Former-commit-id: cbe8a60650a182c061e92cee95223974d7aba1c6
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
…tio#645)

* Mount Citadel CA cert to data plane and config istiod CA provider

* Change the mount path

* Remove an environmental variable
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
* Export Logger and NewLogger

* Fix test error

* Fix lint error
0x01001011 pushed a commit to thedemodrive/istio that referenced this issue Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants