Add ingress support for grafana and prometheus #10699
Conversation
|
/assign @sdake |
|
/retest |
There was a problem hiding this comment.
Nice work. The defaults of false make sense given that we can't assume HTTPS will be available on ingress LBs. I believe the ingressgateway implementation has solved this problem already. If you are up for the challenge, it would be helpful to have https enabled in the ingress model as well.
You also might try a rebase to get your code running in the gate properly.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, gyliu513, sdake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
clyang82
force-pushed
the
add_ingress_grafana_prometheus
branch
from
8af4f2d
to
899eb5f
Compare
|
/retest |
|
@sdake I will have another PR to handle https enabled in the ingress model. Thanks. |
|
/retest |
|
@clyang82 can you resolve conflict pls? |
Signed-off-by: clyang82 <clyang@cn.ibm.com>
clyang82
force-pushed
the
add_ingress_grafana_prometheus
branch
from
899eb5f
to
5c9bc0f
Compare
|
/test istio-pilot-multicluster-e2e |
|
@clyang82: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sorry. the previous one (#9450) is closed by accident.
Let us use this new one to add ingress for grafana and prometheus to be consistent with other. This decision was made in this pr: #9217
Signed-off-by: clyang82 clyang@cn.ibm.com