Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress for grafana and prometheus #9450

Closed

Conversation

clyang82
Copy link
Member

Signed-off-by: Chun Lin Yang clyang@cn.ibm.com

Add ingress for grafana and prometheus to be consistent with other. This decision was made in this pr: #9217

@gyliu513
Copy link
Member

/cc @sdake

@stale
Copy link

stale bot commented Nov 6, 2018

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Nov 6, 2018
Copy link
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stale stale bot removed the stale label Nov 6, 2018
@istio-testing istio-testing added lgtm needs-rebase Indicates a PR needs to be rebased before being merged labels Nov 6, 2018
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 15, 2018
@stale
Copy link

stale bot commented Nov 29, 2018

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Nov 29, 2018
@sdake
Copy link
Member

sdake commented Dec 26, 2018

@clyang82 master is frozen atm. Can you submit this to release-1.1 branch? There has been development in this area, and I am not keen to create a problem for the TOC doing forward porting.

Cheers
-steve

@stale stale bot removed the stale label Dec 26, 2018
@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #9450 into release-1.1 will increase coverage by 3%.
The diff coverage is 89%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-1.1   #9450     +/-   ##
=============================================
+ Coverage           68%     70%     +3%     
=============================================
  Files              578     436    -142     
  Lines            49159   40706   -8453     
=============================================
- Hits             33198   28441   -4757     
+ Misses           14139   10899   -3240     
+ Partials          1822    1366    -456
Impacted Files Coverage Δ
pilot/pkg/model/authentication.go 86% <ø> (ø) ⬇️
security/pkg/nodeagent/sds/sdsservice.go 59% <ø> (-9%) ⬇️
galley/pkg/crd/validation/validation.go 50% <0%> (+17%) ⬆️
galley/pkg/kube/source/source.go 100% <100%> (ø) ⬆️
mixer/pkg/api/grpcServer.go 100% <100%> (+3%) ⬆️
mixer/pkg/attribute/protoBag.go 100% <100%> (ø) ⬆️
galley/pkg/kube/converter/converter.go 92% <86%> (ø) ⬇️
mixer/adapter/inventory.gen.go 0% <0%> (-100%) ⬇️
pilot/pkg/networking/plugin/mixer/mixer.go 1% <0%> (-77%) ⬇️
galley/pkg/meshconfig/cache.go 0% <0%> (-63%) ⬇️
... and 306 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97a89f...d885cfd. Read the comment docs.

@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged and removed approved labels Dec 27, 2018
@clyang82 clyang82 changed the base branch from master to release-1.1 December 27, 2018 07:05
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes labels Dec 27, 2018
@clyang82
Copy link
Member Author

@sdake Hi Steven, I have switch to release-1.1. Please help to review. Thanks.

@clyang82
Copy link
Member Author

/retest

@clyang82
Copy link
Member Author

/assign @sdake

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 27, 2018
Copy link
Member

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@morvencao
Copy link
Member

/retest

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Dec 28, 2018
@clyang82
Copy link
Member Author

/test e2e-mixer-no_auth
/test e2e-dashboard

Copy link
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@clyang82
Copy link
Member Author

clyang82 commented Jan 1, 2019

/retest

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes labels Jan 1, 2019
@istio-testing
Copy link
Collaborator

istio-testing commented Jan 1, 2019

@clyang82: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-mixer-no_auth-mcp.sh ce739d190e5bf10e7b2020be46a1178dbe8e36be link /test e2e-mixer-no_auth-mcp
prow/istio-integ-k8s-tests.sh 0abac6a420b1a061f2ef86e4692498a70dead7d4 link /test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, gyliu513, morvencao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants