New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingress for grafana and prometheus #9450
Conversation
/cc @sdake |
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ce739d1
to
8af677d
Compare
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
@clyang82 master is frozen atm. Can you submit this to release-1.1 branch? There has been development in this area, and I am not keen to create a problem for the TOC doing forward porting. Cheers |
8af677d
to
0abac6a
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.1 #9450 +/- ##
=============================================
+ Coverage 68% 70% +3%
=============================================
Files 578 436 -142
Lines 49159 40706 -8453
=============================================
- Hits 33198 28441 -4757
+ Misses 14139 10899 -3240
+ Partials 1822 1366 -456
Continue to review full report at Codecov.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@sdake Hi Steven, I have switch to |
/retest |
/assign @sdake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
/retest |
0abac6a
to
7960b12
Compare
CLAs look good, thanks! |
/test e2e-mixer-no_auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
7960b12
to
103166a
Compare
New changes are detected. LGTM label has been removed. |
/retest |
7256469
to
d885cfd
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@clyang82: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
d885cfd
to
f97a89f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, gyliu513, morvencao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Chun Lin Yang clyang@cn.ibm.com
Add ingress for grafana and prometheus to be consistent with other. This decision was made in this pr: #9217