Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick changes from 1.0 - Fix deployment namespace #7446 (#7477) #13629

Closed
wants to merge 1 commit into from

Conversation

ericvn
Copy link
Contributor

@ericvn ericvn commented Apr 25, 2019

Cherrypicked commit:

Signed-off-by: Sébastien Prud'homme sebastien.prudhomme@gmail.com

Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com>
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Apr 25, 2019
@ericvn ericvn changed the title Fix deployment namespace #7446 (#7477) Cherrypick changes from 1.0 - Fix deployment namespace #7446 (#7477) Apr 25, 2019
@ericvn ericvn changed the title Cherrypick changes from 1.0 - Fix deployment namespace #7446 (#7477) Cherry-pick changes from 1.0 - Fix deployment namespace #7446 (#7477) Apr 25, 2019
@ericvn
Copy link
Contributor Author

ericvn commented Apr 25, 2019

@sebastien-prudhomme Are you OK with me cherry picking the changes forward to master and release-1.1? Asking to get the required CLA sign-off.

@ericvn
Copy link
Contributor Author

ericvn commented Apr 25, 2019

First portion of #13625

@ericvn
Copy link
Contributor Author

ericvn commented Apr 25, 2019

/assign @ayj

@ayj ayj requested review from ozevren and removed request for ayj April 25, 2019 22:39
@ayj ayj assigned ozevren and unassigned ayj Apr 25, 2019
@istio-testing
Copy link
Collaborator

@ericvn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh 87c3a1f link /test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren
Copy link
Contributor

ozevren commented Apr 26, 2019

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericvn, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericvn
Copy link
Contributor Author

ericvn commented Apr 30, 2019

Closing this PR as I can see that the change made it into the new installer code.

@ericvn ericvn closed this Apr 30, 2019
@ericvn ericvn deleted the cherryPick7446 branch May 7, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants