New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the app handling path register. #14432
Conversation
@incfly: GitHub didn't allow me to request PR reviews from the following users: wat. Note that only istio members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @wattli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@incfly |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, incfly, wattli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-simpleTests-master |
@incfly: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test integ-framework-k8s-presubmit-tests-master |
/test istio-unit-tests-master |
I think we handling at "/" previously because we planned to use original path for health check but we decided to rewrite using injector later, that becomes no longer needed. Meanwhile it spams the error log causing confusion.