Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the app handling path register. #14432

Merged
merged 6 commits into from Jun 14, 2019
Merged

Conversation

incfly
Copy link

@incfly incfly commented May 29, 2019

I think we handling at "/" previously because we planned to use original path for health check but we decided to rewrite using injector later, that becomes no longer needed. Meanwhile it spams the error log causing confusion.

@istio-testing
Copy link
Collaborator

@incfly: GitHub didn't allow me to request PR reviews from the following users: wat.

Note that only istio members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Wat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@incfly
Copy link
Author

incfly commented Jun 5, 2019

/cc @wattli

@istio-testing istio-testing requested a review from wattli June 5, 2019 21:47
Copy link
Contributor

@wattli wattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@howardjohn
Copy link
Member

@incfly istio.io/istio/pilot/cmd/pilot-agent/status/server.go:-5.700000% (66.700000% to 61.000000%) codecov fails

@howardjohn
Copy link
Member

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, incfly, wattli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly
Copy link
Author

incfly commented Jun 14, 2019

/test e2e-simpleTests-master
/test integ-framework-local-presubmit-tests-master
/test integ-galley-local-presubmit-tests-master

@istio-testing
Copy link
Collaborator

istio-testing commented Jun 14, 2019

@incfly: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests-minProfile.sh 841c029 link /test e2e-simpleTestsMinProfile-master
prow/integ-pilot-k8s-presubmit-tests.sh f693ec7 link /test integ-pilot-k8s-presubmit-tests-master
prow/integ-mixer-k8s-presubmit-tests.sh f693ec7 link /test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly
Copy link
Author

incfly commented Jun 14, 2019

/test integ-framework-k8s-presubmit-tests-master

@howardjohn
Copy link
Member

/test istio-unit-tests-master

@istio-testing istio-testing merged commit 2b5bf69 into istio:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants