Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toleration for Istio components. (bp #13044) #15081

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 22, 2019

This is an automated backport of pull request #13044 done by Mergify.io

* add toleration for Istio components.

* apply comments.

(cherry picked from commit f91f99e)
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jun 22, 2019
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mergify[bot]
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram

If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

Hi @mergify[bot]. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@morvencao
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 22, 2019
@fpesce fpesce added cla: human-approved and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jun 24, 2019
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@fpesce
Copy link
Contributor

fpesce commented Jun 24, 2019

CLA: signed-off in original PR.

@howardjohn howardjohn closed this Jun 24, 2019
@howardjohn howardjohn reopened this Jun 24, 2019
@mergify mergify bot closed this Jun 24, 2019
@mergify mergify bot deleted the mergify/bp/release-1.2/pr-13044 branch June 24, 2019 18:13
@howardjohn howardjohn restored the mergify/bp/release-1.2/pr-13044 branch June 24, 2019 18:14
@howardjohn howardjohn reopened this Jun 24, 2019
@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.2@afba09e). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.2   #15081   +/-   ##
==============================================
  Coverage               ?      77%           
==============================================
  Files                  ?      495           
  Lines                  ?    48386           
  Branches               ?        0           
==============================================
  Hits                   ?    37023           
  Misses                 ?     9474           
  Partials               ?     1889

@fpesce fpesce merged commit 31b3b02 into release-1.2 Jun 24, 2019
@mergify mergify bot deleted the mergify/bp/release-1.2/pr-13044 branch June 24, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants