Add legacy varient to kind config patch #16176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config patch provided only works on 1.15, but we test on older kubernetes versions for backwards compatibility, so we need another variant to support these.
googlebot
added
the
cla: yes
istio-testing
added
the
size/M
pitlv2109
reviewed
Aug 10, 2019
prow/config/trustworthy-jwt-12.yaml
Outdated
| @@ -0,0 +1,14 @@ | |||
| # This configs KinD to spin up a k8s cluster with trustworthy jwt (Service Account Token Volume Projection) feature. | |||
| # This must be used for 1.14 and 1.13 k8s versions | |||
|
@howardjohn: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
In response to a cherrypick label: new pull request created: #16250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config patch provided only works on 1.15, but we test on older
kubernetes versions for backwards compatibility, so we need another
variant to support these.
This fixes postsubmit test failures like https://prow.istio.io/view/gcs/istio-prow/logs/integ-k8s-112-postsubmit-master/147