Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Prometheus endpoint #17264

Closed
wants to merge 4 commits into from
Closed

Fix Prometheus endpoint #17264

wants to merge 4 commits into from

Conversation

goruha
Copy link

@goruha goruha commented Sep 20, 2019

Fix jaeger metrics port

The port was changed in this PR

jaegertracing/jaeger#1332
jaegertracing/jaeger#1442

image

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

[ x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@goruha goruha requested a review from a team as a code owner September 20, 2019 11:08
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2019
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Sep 20, 2019
@istio-testing
Copy link
Collaborator

Hi @goruha. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@morvencao
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 20, 2019
{{- if .Values.contextPath }}
prometheus.io/path: "{{ .Values.contextPath }}/metrics"
{{- else }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this, contextPath can be empty string.

@istio-testing
Copy link
Collaborator

@goruha: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integ-pilot-local-tests_istio f9b27b8 link /test integ-pilot-local-tests
pilot-multicluster-e2e_istio f9b27b8 link /test pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid
Copy link
Contributor

is this superseded by #17522 ?

@objectiser
Copy link
Contributor

@douglas-reid yes

@douglas-reid
Copy link
Contributor

@objectiser OK. thanks.

@goruha Thanks for this PR. Because #17522 will achieve the same result (in addition to other things), I'm going to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants