Add support for docker buildkit, speeding up docker builds 5-10x #19156
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Copyright 2019 Istio Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -eu | ||
|
|
||
| out="${1}" | ||
| config="${out}/docker-bake.hcl" | ||
| shift | ||
|
|
||
| variants=$(for i in ${DOCKER_ALL_VARIANTS}; do echo "\"${i}\""; done | xargs -d'\n' | sed -e 's/ /, /g') | ||
| cat <<EOF > "${config}" | ||
| group "all" { | ||
| targets = [${variants}] | ||
| } | ||
| EOF | ||
|
|
||
| # Generate the top header. This defines a group to build all images for each variant | ||
| for variant in ${DOCKER_ALL_VARIANTS}; do | ||
| # Get all images. Transform from `docker.target` to `"target"` as a comma seperated list | ||
| images=$(for i in "$@"; do echo "\"${i#docker.}-${variant}\""; done | xargs -d'\n' | sed -e 's/ /, /g') | ||
| cat <<EOF >> "${config}" | ||
| group "${variant}" { | ||
| targets = [${images}] | ||
| } | ||
| EOF | ||
| done | ||
|
|
||
| # For each docker image, define a target to build it | ||
| for file in "$@"; do | ||
| for variant in ${DOCKER_ALL_VARIANTS}; do | ||
| image=${file#docker.} | ||
| tag="${TAG}" | ||
| output="${image}" | ||
| # The default variant has no suffix, others do | ||
| if [[ "${variant}" != "default" ]]; then | ||
| tag+="-${variant}" | ||
| output+="-${variant}" | ||
| fi | ||
| # Add output only if docker save is specified | ||
| outputfield="" | ||
| if [[ -n "${DOCKER_SAVE:-}" ]]; then | ||
| outputfield="output = [\"type=tar,dest=${ISTIO_DOCKER_TAR}/${output}.tar\"]" | ||
| fi | ||
| cat <<EOF >> "${config}" | ||
| target "$image-$variant" { | ||
| context = "${out}/${file}" | ||
| dockerfile = "Dockerfile.$image" | ||
| tags = ["${HUB}/${image}:${tag}"] | ||
| args = { | ||
| BASE_VERSION = "${BASE_VERSION}" | ||
| BASE_DISTRIBUTION = "${variant}" | ||
| } | ||
| ${outputfield} | ||
| } | ||
| EOF | ||
| # For the default variant, create an alias so we can do things like `build pilot` instead of `build pilot-default` | ||
| if [[ "${variant}" == "default" ]]; then | ||
| cat <<EOF >> "${config}" | ||
| target "$image" { | ||
| inherits = ["$image-$variant"] | ||
| } | ||
| EOF | ||
| fi | ||
| done | ||
| done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not strictly necessary, but is another optimization made possible by this change. This way both CI and dev experience is optimized