Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix names of istio-iptables scripts called in Debian package #20002

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fix names of istio-iptables scripts called in Debian package #20002

merged 1 commit into from
Jan 8, 2020

Conversation

rlenglet
Copy link
Contributor

@rlenglet rlenglet commented Jan 8, 2020 •
edited
Loading

In 1.4 only, we still use the shell script versions of the istio-iptables scripts, but the Debian package's istio-start.sh script was calling the commands without the .sh suffix like in master.

Fixes #17989
Fixes #17615
Fixes #19615

@rlenglet rlenglet requested a review from a team January 8, 2020 17:42
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 8, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2020
@istio-testing
Copy link
Collaborator

@rlenglet: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integ-mixer-k8s-tests_istio_release-1.4 f073580 link /test integ-mixer-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 8e4fb0a into release-1.4 Jan 8, 2020
@istio-testing istio-testing deleted the fix-iptables-clean-on-vm branch January 8, 2020 18:35
brian-avery pushed a commit to brian-avery/istio that referenced this pull request Mar 4, 2020
@rlenglet
Fix names of istio-iptables scripts called in Debian package (istio#2…
4b905e4 
…0002)

Fixes istio#17989
Fixes istio#17615
brian-avery pushed a commit to brian-avery/istio that referenced this pull request Mar 4, 2020
@rlenglet
Fix names of istio-iptables scripts called in Debian package (istio#2…
dc5635b 
…0002)

Fixes istio#17989
Fixes istio#17615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
area/environments area/networking cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rlenglet @istio-testing @howardjohn @googlebot