Setup workload SDS for egress #20543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now egress is in a pretty broken state because we expect everything to be on SDS, but egress isn't. If we turn SDS on, we get Ingress SDS which is broken for Egress. This attempts to get just workload SDS, not Gateway sds. For istio#20535
istio-testing
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
istio-testing
added
the
size/M
istio-testing
removed
the
do-not-merge/work-in-progress
JimmyCYJ
reviewed
Jan 27, 2020
There was a problem hiding this comment.
Can we have any integration test, or restore the TestSdsEgressGatewayIstioMutual to cover this change?
https://github.com/istio/istio/blob/master/tests/integration/security/sds_egress/sds_istio_mutual_egress_test.go
JimmyCYJ
approved these changes
Jan 27, 2020
elfinhe
approved these changes
Jan 27, 2020
This was referenced Jan 28, 2020
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Jan 29, 2020
Right now egress is in a pretty broken state because we expect everything to be on SDS, but egress isn't. If we turn SDS on, we get Ingress SDS which is broken for Egress. This attempts to get just workload SDS, not Gateway sds. For istio#20535 (cherry picked from commit f94d9b5)
istio-testing
pushed a commit
that referenced
this pull request
Jan 30, 2020
* Setup workload SDS for egress (#20543) Right now egress is in a pretty broken state because we expect everything to be on SDS, but egress isn't. If we turn SDS on, we get Ingress SDS which is broken for Egress. This attempts to get just workload SDS, not Gateway sds. For #20535 (cherry picked from commit f94d9b5) * Istiod/fix ingress sds (#20625) * Fix ingress SDS * Temporarily turn on all tests * Revert "Temporarily turn on all tests" This reverts commit 4dd318e5401820cf2cf7d4c2451beede0c962a96. * fix merge (cherry picked from commit 3940640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now egress is in a pretty broken state because we expect
everything to be on SDS, but egress isn't. If we turn SDS on, we get
Ingress SDS which is broken for Egress. This attempts to get just
workload SDS, not Gateway sds.
For #20535