Fix xds version set and status reporter

[hzxuzhonghu]

Currently, the version is not consistent across xds.
This pr:

1. makes all cds response use the version from passed one

2. fix status reporter, record event for no ops push

[howardjohn]

fix status reporter, no record during push

This is working as intended, which is why the test fails. Why do you think it should not record? We consider not pushing == the envoy was updated, since the update is a NOP

[howardjohn]

Oh I see - we are supposed to record on the ACK not on the send. I think we still need the for _, distributionType := range AllEventTypes { part though?

cc @therealmitchconnors

[hzxuzhonghu]

I will take a look at the test.

[hzxuzhonghu]

/retest

[hzxuzhonghu]

/test integ-pilot-k8s-tests_istio

[istio-testing]

@hzxuzhonghu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hzxuzhonghu]

outdated