Implement REPLACE operation for EnvoyFilter patch #27426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
istio-testing
added
the
size/L
zhaohuabing
changed the title
|
/retest |
Add a "REPLACE" operation for EnvoyFilter patch. This operation only supports Network filter and HTTP filter. This is the implementation of issue istio#27425 Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
envoyfilter-replace-operation
branch
from
01d5ba5
to
70fd431
Compare
mandarjog
reviewed
Sep 19, 2020
pilot/pkg/networking/core/v1alpha3/envoyfilter/listener_patch_test.go
Outdated
Show resolved
Hide resolved
Add debug info when no matching filter found. Add negative test. Change test case name to indicate http filter. Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
hzxuzhonghu
approved these changes
Sep 21, 2020
howardjohn
reviewed
Sep 21, 2020
| - 27425 | ||
| releaseNotes: | ||
| - | | ||
| **Added** "REPLACE" operation for EnvoyFilter. "REPLACE" opration can replace contents of a named filter with new contents. It is only valid for HTTP_FILTER and NETWORK_FILTER. |
There was a problem hiding this comment.
Suggested change
| **Added** "REPLACE" operation for EnvoyFilter. "REPLACE" opration can replace contents of a named filter with new contents. It is only valid for HTTP_FILTER and NETWORK_FILTER. | |
| **Added** "REPLACE" operation for EnvoyFilter. "REPLACE" operation can replace contents of a named filter with new contents. It is only valid for HTTP_FILTER and NETWORK_FILTER. |
There was a problem hiding this comment.
Sorry for the typo, how could I fix it? This has already been merged.
|
You can send another PR I guess. Sorry didn't see it had been merged.
Thanks for the PR!
…On Mon, Sep 21, 2020 at 6:38 PM zhaohuabing ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In releasenotes/notes/27425.yaml
<#27426 (comment)>:
> @@ -0,0 +1,8 @@
+apiVersion: release-notes/v2
+kind: bug-fix
+area: traffic-management
+issue:
+ - 27425
+releaseNotes:
+ - |
+ **Added** "REPLACE" operation for EnvoyFilter. "REPLACE" opration can replace contents of a named filter with new contents. It is only valid for HTTP_FILTER and NETWORK_FILTER.
Sorry for the typo, how could I fix it? This has already been merged.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#27426 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXJZ3WRDGFTH7R73DMLSG752DANCNFSM4RTBD4NA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "REPLACE" operation for EnvoyFilter patch. This operation only supports Network filter and HTTP filter.
This is the implementation of issue #27425
Signed-off-by: huabing zhao zhaohuabing@gmail.com
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[*] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.