Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conflicting STATIC variable from build #28151

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Remove conflicting STATIC variable from build #28151

merged 1 commit into from
Oct 21, 2020

Commits on Oct 21, 2020

  1. Remove conflicting STATIC variable from build 

    We currently set `STATIC=0 LDFLAGS='-extldflags -static -s -w'` as part of the
build. This does not make much sense, since STATIC sets LDFLAGS to
empty, so we don't pass `-static -s -w`.

I believe we do want to pass these flags, as they were originally added
for a reason.

Binary size changes for istioctl, agent, and pilot in mb:
```
114 -> 81
104 -> 75
108 -> 77
```

Helps with istio#26232
    @howardjohn
    howardjohn committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    d86d8db View commit details
    Browse the repository at this point in the history