Move fake XDS server into dedicated package #28673
Conversation
Aside from general code hygiene, this is required by istio#26232 to allow the agent to be built without importing the entire world (ie Kubernetes)
howardjohn
added
the
release-notes-none
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/L
|
this doesn't work due to circular import. not sure if its possible to get around that 😕 |
|
@howardjohn: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
istio-testing
added
the
needs-rebase
|
@howardjohn: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -39,6 +39,7 @@ import ( | |||
| kubesecrets "istio.io/istio/pilot/pkg/secrets/kube" | |||
| "istio.io/istio/pilot/pkg/serviceregistry" | |||
| kube "istio.io/istio/pilot/pkg/serviceregistry/kube/controller" | |||
| "istio.io/istio/pilot/pkg/xds" | |||
There was a problem hiding this comment.
It must be circular import with xds, maybe try changing the xds_test.go to another package can solve this?
|
obsolete by #29003 |
Aside from general code hygiene, this is required by
#26232 to allow the agent to be
built without importing the entire world (ie Kubernetes)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.