Drop dependency on the operator from the agent #28674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/S
Agent -> pkg/xds -> debug.go -> inject/ -> operator/ Cut the chain at debug.go to not import inject/ Agent binary size 77.9mb -> 76.8mb
howardjohn
force-pushed
the
pilot/drop-operator-import
branch
from
c68c0df
to
626ffea
Compare
|
/retest |
rlenglet
approved these changes
Nov 7, 2020
ramaraochavali
approved these changes
Nov 8, 2020
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent -> pkg/xds -> debug.go -> inject/ -> operator/
Cut the chain at debug.go to not import inject/
Agent binary size 77.9mb -> 76.8mb
Part of #26232
Also will be required long term to drop k8s dependency, so its not just 1mb