[1.7] Trim agent binary by 14mb by conditionally compiled XDS filters (#28670) #28717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o#28670) * Trim agent binary by 11mb by conditionally compiled XDS filters Part of istio#26232 75mb -> 64mb We could have also done massive refactoring to avoid using build tags, but I think in the near future we will need build tags for dropping k8s import, so it seems useful to implement this at least for the short term. * Trim another 4mb (cherry picked from commit 19c8ea4)
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/M
howardjohn
changed the title
howardjohn
added
the
release-notes-none
|
/retest |
JimmyCYJ
approved these changes
Nov 9, 2020
incfly
pushed a commit
to incfly/istio
that referenced
this pull request
Apr 13, 2022
…o#28670) (istio#28717) * Trim agent binary by 11mb by conditionally compiled XDS filters Part of istio#26232 75mb -> 64mb We could have also done massive refactoring to avoid using build tags, but I think in the near future we will need build tags for dropping k8s import, so it seems useful to implement this at least for the short term. * Trim another 4mb (cherry picked from commit 19c8ea4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26232
75mb -> 64mb
We could have also done massive refactoring to avoid using build tags,
but I think in the near future we will need build tags for dropping k8s
import, so it seems useful to implement this at least for the short
term.
(cherry picked from commit 19c8ea4)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.