Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run echo as non root. #31568

Merged
merged 4 commits into from Mar 19, 2021
Merged

Run echo as non root. #31568

merged 4 commits into from Mar 19, 2021

Conversation

bianpengyuan
Copy link
Contributor

@bianpengyuan bianpengyuan commented Mar 19, 2021 •
edited

I make it run as non-root by default, since I think this is the most cases in reality. I can make this an option if this is not desired. For #28256.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 19, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 19, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2021
@bianpengyuan
Copy link
Contributor Author

/test all

@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bianpengyuan
Copy link
Contributor Author

/test all

@bianpengyuan bianpengyuan added the release-notes-none Indicates a PR that does not require release notes. label Mar 19, 2021
@bianpengyuan
Copy link
Contributor Author

/retest

@bianpengyuan bianpengyuan marked this pull request as ready for review March 19, 2021 02:54
@bianpengyuan bianpengyuan requested a review from a team as a code owner March 19, 2021 02:54
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 19, 2021
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2021
@stevenctl stevenctl added the do-not-merge/hold Block automatic merging of a PR. label Mar 19, 2021
stevenctl
stevenctl approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@stevenctl stevenctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put hold to allow a second pair of eyes, LGTM

@bianpengyuan
Copy link
Contributor Author

@howardjohn @nmittler for another pair of eyes. thanks!

@bianpengyuan bianpengyuan removed the do-not-merge/hold Block automatic merging of a PR. label Mar 19, 2021
@istio-testing istio-testing merged commit 2a69579 into istio:master Mar 19, 2021
bianpengyuan added a commit to bianpengyuan/istio that referenced this pull request Mar 19, 2021
@bianpengyuan
Run echo as non root. (istio#31568)
88a3d5b 
* Run echo as non root.

* fix

* fix

* test
istio-testing pushed a commit that referenced this pull request Mar 19, 2021
@bianpengyuan
[release-1.9] echo fixes for cert file and non-root user. (#31582)
28bbe29 
* Run echo as non root. (#31568)

* Run echo as non root.

* fix

* fix

* test

* Make echo able to use cert files for call. (#31561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@stevenctl stevenctl stevenctl approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bianpengyuan @istio-testing @howardjohn @stevenctl