Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include EDS in configdump #31942

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Include EDS in configdump #31942

merged 1 commit into from
Apr 6, 2021

Conversation

howardjohn
Copy link
Member

Just get some more info

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Apr 6, 2021
@howardjohn howardjohn requested a review from a team as a code owner April 6, 2021 18:19
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 6, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2021
@howardjohn
Copy link
Member Author

/retest

stevenctl
stevenctl approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@stevenctl stevenctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What additional info do we get here that we don't get in :15000/clusters

@howardjohn
Copy link
Member Author

Not that much. But seeing the version would have helped with #31943 a bit.

@istio-testing istio-testing merged commit 6ba00c8 into istio:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenctl stevenctl stevenctl approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@howardjohn @stevenctl @istio-testing