Automatically detect ROUTER_MODE #33129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/M
stevenctl
approved these changes
May 26, 2021
howardjohn
force-pushed
the
pilot/auto-auto-passthrough
branch
from
35c6b64
to
f226429
Compare
|
/retest |
1 similar comment
|
/retest |
|
/hold for a while Just give @costinm @ramaraochavali @mandarjog a chance to take a look, in case this causes some unexpected behavior |
|
SGTM. The main concern I have is that when we add or remove the AUTO_PASSTHROUGH we add/remove a bunch of clusters.. but that seems fine. Generally its a one time action |
|
I thought the time sequence of gateway creation, but could not think of any caveats. LGTM |
|
/retest |
ramaraochavali
approved these changes
May 27, 2021
|
unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33127