Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark and optimize PushRequest #35189

Merged
merged 1 commit into from Sep 15, 2021

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Sep 14, 2021

While this is a seemingly innocent code path, it shows up in pprof's a lot - like 5-10%+ of CPU and allocs.

name           old time/op    new time/op    delta
PushRequest-6    6.15ms ± 1%    5.42ms ± 8%  -11.87%  (p=0.002 n=6+6)

name           old alloc/op   new alloc/op   delta
PushRequest-6    4.24MB ± 0%    3.48MB ± 0%  -17.94%  (p=0.002 n=6+6)

name           old allocs/op  new allocs/op  delta
PushRequest-6     85.1k ± 0%     60.1k ± 0%  -29.39%  (p=0.000 n=5+6)

This will get faster with the fixes in census-instrumentation/opencensus-go#1265 as well

@howardjohn howardjohn requested review from a team as code owners September 14, 2021 18:34
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Sep 14, 2021
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2021
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Sep 14, 2021
@howardjohn
Copy link
Member Author

/retest

@istio-testing istio-testing merged commit 465c3fa into istio:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants