Fix alt-host generation when hostname has a partial overlap with cluster domain #35691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/L
howardjohn
commented
Oct 20, 2021
| @@ -622,5 +623,13 @@ func getUniqueAndSharedDNSDomain(fqdnHostname, proxyDomain string) (partsUnique | |||
| partsUnique = reverseArray(partsFQDNInReverse[len(sharedSuffixesInReverse):]) | |||
| partsShared = reverseArray(sharedSuffixesInReverse) | |||
| } | |||
| if strings.Contains(proxyDomain, ".svc.") { | |||
There was a problem hiding this comment.
I implemented 2 fixes, I think both are not great. Left both to see what others thought, and put a hold for now.
The alternative is to have entirely different logic for k8s, (line499), which I think is better although the code could be cleaned up..
There was a problem hiding this comment.
@ramaraochavali lmk what you think
There was a problem hiding this comment.
Sorry. I missed this. It seems having entirely different logic for k8s is much cleaner
|
Sorry missed this noitification |
…ter domain For example, a service `foo.bar.local` behaves incorrectly because we incorrectly match the `.local` up with `.cluster.local`
howardjohn
force-pushed
the
pilot/fix-alt-hosts
branch
from
17ab87b
to
1fe5ed2
Compare
howardjohn
force-pushed
the
pilot/fix-alt-hosts
branch
from
1fe5ed2
to
62c8314
Compare
howardjohn
commented
Oct 28, 2021
| } | ||
|
|
||
| testFn := func(service *model.Service, port int, node *model.Proxy, want []string) error { | ||
| out, _ := generateVirtualHostDomains(service, port, node) | ||
| sort.SliceStable(want, func(i, j int) bool { return want[i] < want[j] }) |
There was a problem hiding this comment.
remove sort to make sure I didn't change the order. we should be conscious of changing the order.
|
/retest |
ramaraochavali
approved these changes
Nov 8, 2021
ericvn
approved these changes
Nov 8, 2021
|
/retest
…On Mon, Nov 8, 2021 at 6:41 AM Istio Automation ***@***.***> wrote:
@howardjohn <https://github.com/howardjohn>: The following test *failed*,
say /retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
integ-security-multicluster-tests_istio a4c781f
<a4c781f>
link
<https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/35691/integ-security-multicluster-tests_istio/1457711874731675648>
unknown /test integ-security-multicluster-tests_istio
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35691 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXIF7GLO4ULVGWQGTLLUK7OSHANCNFSM5GMGHR7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
We're experiencing this issue in istio 1.11.7. Is it will be fixed in 1.11.x or 1.12.x? I saw a fix in 1.13.0 release notes only |
|
This is currently only fixed in 1.13.0+ |
|
Yes, I saw this. My question is: Do you guys have plans to fix this issue in 1.11.X? This release is still in maintenance, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, a service
foo.bar.localbehaves incorrectly because weincorrectly match the
.localup with.cluster.localFixes #35676