Remove --strict from helm linter #36996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/XS
jacob-delgado
approved these changes
Jan 25, 2022
jacob-delgado
added
the
release-notes-none
|
/test release-notes_istio |
|
just want a sec to review before automerge |
|
cc @ericvn any reason why you are removing this? Failing on lint warnings seems like the behavior we'd want, but maybe there's additional things I'm missing. |
|
@jacob-delgado Reason it's failing is that we moved up Helm versions in the build image. Separate Slack with John as well. Not sure if it makes sense to remove the --strict, update the manifests to fix warnings (will this break us on some older supported kk8s versions, or revert the Helm update. |
|
Ah its from deprecated APIs... we cannot remove those yet |
howardjohn
approved these changes
Jan 25, 2022
|
Removing DNM as John approved. Still waiting on @istio/wg-environments-maintainers . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
The Helm version was updated in the tooling, so there are now some WARNINGS (which fail because of --strict) on deprecated APIs.
The
make genalso makes one other manifest change.To help us figure out who should review this PR, please put an X in all the areas that this PR affects.