ambient: integrate ztunnel builds #41633
Merged
+214
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Icfbdcafa953d3af16307490d552a00d44e857866
stevenctl
requested review from
howardjohn,
linsun and
dhawton
as code owners
istio-testing
added
the
size/L
added 3 commits
October 25, 2022 14:57
Change-Id: Ic91b929bf9afd3fff272f3acc6c439a0246ff8c3
Change-Id: Icbf04c969e9eca0c07ea336fd0f7859e48a79496
Change-Id: I46d9b96895e12c40774c18507bba1ad6571590c5
stevenctl
changed the title
|
/test all |
howardjohn
approved these changes
Oct 27, 2022
howardjohn
reviewed
Oct 27, 2022
| @@ -244,9 +244,6 @@ spec: | |||
| httpGet: | |||
| port: 15020 # TODO: use 15021, but it spams logs | |||
There was a problem hiding this comment.
We should probably make this 15021 (should work for envoy) then switch the ztunnel code to use 15021 as well.
In the meantime I suspect it won't get marked as ready
|
/test integ-ambient |
added 3 commits
October 31, 2022 10:49
Change-Id: Iba1f99f5942653b512ab966e450568e2bfbf53d1
Change-Id: I65f6a4e4979fad618bc46b83062a19b069dc7125
hzxuzhonghu
reviewed
Nov 2, 2022
| cp -f "${2}" "${TARGET_OUT_LINUX}/ztunnel" | ||
| } | ||
|
|
||
| function maybe_build_ztunnel() { |
There was a problem hiding this comment.
Why not download like envoy proxy? IMO this will couple ztunnel and istio
There was a problem hiding this comment.
"maybe" - by default we download it.
Rust proxy is 100x easier to build locally. If I'm quickly iterating on both proxy and control plane, this allows triggering the build of both in one step.
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the Istio repo to depend on https://github.com/isito/ztunnel
Usage
../ztunneland try to build from rust.make docker.ztunnelfor rapid iteration with control plane + ztunnel changes.