Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align cobra help message to capital letter #42084

Closed
wants to merge 1 commit into from
Closed

Align cobra help message to capital letter #42084

wants to merge 1 commit into from

Conversation

yanggangtony
Copy link
Member

Signed-off-by: yanggang gang.yang@daocloud.io

Most of cobra help info is begin with "capital letter ".
So we should keep the style the same.

@yanggangtony yanggangtony requested review from a team as code owners November 21, 2022 07:16
@google-cla
Copy link

google-cla bot commented Nov 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Nov 21, 2022
@istio-testing
Copy link
Collaborator

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the ones referencing commands (most of them) should not be capitalized

istioctl/cmd/add-to-mesh.go Outdated Show resolved Hide resolved
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2022
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could not change this is the command usage,

@yanggangtony
Copy link
Member Author

could not change this is the command usage,

@hzxuzhonghu
thanks for review.
pardon me , i can not get your point.

@zhlsunshine
Copy link
Contributor

could not change this is the command usage,

@hzxuzhonghu thanks for review. pardon me , i can not get your point.

it means that this usage can not work well once you change them with capital letter, such as kube-inject can not be changed as Kube-inject.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2022
@yanggangtony
Copy link
Member Author

@zhlsunshine
thanks for reply . updated.

Or just close pr? If you thinks these is not necessary

Signed-off-by: yanggang <gang.yang@daocloud.io>
@zhlsunshine
Copy link
Contributor

@yanggangtony Yeah, I recommend that close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants