Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip confirmation for operator remove if specifying --dry-run #43120

Merged
merged 2 commits into from Feb 4, 2023
Merged

Skip confirmation for operator remove if specifying --dry-run #43120

merged 2 commits into from Feb 4, 2023

Conversation

hanxiaop
Copy link
Member

@hanxiaop hanxiaop commented Feb 3, 2023

Please provide a description of this PR:

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Ambient
  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hanxiaop hanxiaop requested a review from a team as a code owner February 3, 2023 06:26
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2023
@hanxiaop hanxiaop added the release-notes-none Indicates a PR that does not require release notes. label Feb 3, 2023
@hanxiaop
Copy link
Member Author

hanxiaop commented Feb 3, 2023

/test release-notes

@zirain zirain added the do-not-merge Block automatic merging of a PR. label Feb 3, 2023
@zirain
Copy link
Member

zirain commented Feb 3, 2023

worth a release-note for backport?

@hanxiaop hanxiaop requested review from a team as code owners February 3, 2023 07:13
@hanxiaop hanxiaop requested a review from zirain February 3, 2023 07:13
@zirain zirain added area/environments/operator Issues related to Operator or installation and removed do-not-merge Block automatic merging of a PR. release-notes-none Indicates a PR that does not require release notes. labels Feb 3, 2023
ericvn
ericvn reviewed Feb 3, 2023
View reviewed changes
releasenotes/notes/43120.yaml
@@ -0,0 +1,6 @@
apiVersion: release-notes/v2
kind: feature
area: installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might this be better in the istioctl section, at least since it's --dry-run.

@zirain
Copy link
Member

zirain commented Feb 4, 2023

/test release-test

@istio-testing istio-testing merged commit d978f2b into istio:master Feb 4, 2023
@hanxiaop hanxiaop mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvn ericvn ericvn left review comments

@howardjohn howardjohn howardjohn approved these changes

@zirain zirain zirain approved these changes

@morvencao morvencao morvencao approved these changes

Assignees
No one assigned
Labels
area/environments/operator Issues related to Operator or installation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hanxiaop @zirain @howardjohn @morvencao @ericvn @istio-testing