Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint: add depguard/v2 settings #45300

Merged
merged 1 commit into from
Jun 7, 2023
Merged

golangci-lint: add depguard/v2 settings #45300

merged 1 commit into from
Jun 7, 2023

Conversation

zirain
Copy link
Member

@zirain zirain commented Jun 6, 2023 •
edited
Loading

@zirain zirain added the do-not-merge Block automatic merging of a PR. label Jun 6, 2023
@zirain zirain requested a review from a team as a code owner June 6, 2023 08:47
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2023
@zirain zirain mentioned this pull request Jun 6, 2023
Merged
@zirain zirain added release-notes-none Indicates a PR that does not require release notes. area/test and release labels Jun 6, 2023
@zirain
Copy link
Member Author

zirain commented Jun 6, 2023

/test release-notes

howardjohn
howardjohn reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to approve the other PR

common/config/.golangci.yml Outdated Show resolved Hide resolved
@ericvn ericvn mentioned this pull request Jun 6, 2023
Closed
@ericvn
Copy link
Contributor

ericvn commented Jun 6, 2023

I did some testing with the image created in the istio/common-files#845, and if we add the common-files update snippet from the first comment in the tools PR, I think we should be able to let that flow through all the repos. For istio/istio, I think we just need to merge the override file and when the automation creates the PR here, it should be correct as well.

So maybe the order is to get this PR updated so it only has the override file changes and get it merged. I can try and push a small config update in the common-files PR, and we can merge that. Then hopefully everything flows and succeeds.

@zirain
update depguard v2 setting
4ac8119 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2023
@zirain zirain changed the title [DNM] test depguard/v2 golangci-lint: add depguard/v2 settings Jun 7, 2023
@zirain zirain removed the do-not-merge Block automatic merging of a PR. label Jun 7, 2023
@zirain
Copy link
Member Author

zirain commented Jun 7, 2023

Revert most of changes, I think this PR is a presubmit for istio/common-files#844

cc @howardjohn @ericvn

@istio-testing istio-testing merged commit f618007 into istio:master Jun 7, 2023
@zirain zirain deleted the depguard/v2 branch June 8, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
area/test and release release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zirain @ericvn @howardjohn @istio-testing