Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated istio doc repo link. #468

Closed
wants to merge 1 commit into from
Closed

Updated istio doc repo link. #468

wants to merge 1 commit into from

Conversation

gyliu513
Copy link
Member

No description provided.

@istio-testing
Copy link
Collaborator

Jenkins job istio/presubmit passed

Copy link
Contributor

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the help. In this case though your proposed change is worse because the 2 links look like one

@ldemailly
Copy link
Contributor

ldemailly commented Jul 15, 2017

your proposed version is actually less readable:
screen shot 2017-07-15 at 1 19 32 pm
vs current:
screen shot 2017-07-15 at 1 19 02 pm

@ldemailly ldemailly closed this Jul 15, 2017
@gyliu513 gyliu513 deleted the link branch July 15, 2017 23:50
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
Former-commit-id: 314b9b332e88af2dc137a61108b9b146d1ee9d19
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
Former-commit-id: c68d30478e9a998a03e0e07b3dfa7f1f7d8a76df
howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants