gateway-api: support removing path prefix #47254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-policy-bot
added
area/networking
release-notes-none
istio-testing
added
the
size/L
howardjohn
reviewed
Oct 12, 2023
| action.PrefixRewrite = uri | ||
| if model.UseGatewaySemantics(vs) && uri == "/" { | ||
| // remove the prefix | ||
| action.RegexRewrite = &matcher.RegexMatchAndSubstitute{ |
There was a problem hiding this comment.
AFAIK this is the same case as cilium/cilium#28294 tries to solve, but they do it differently. We should probably find the best way and make sure implementations are aligned.
There was a problem hiding this comment.
I don't think cilium/cilium#28294 is correct:
route.Route.RegexRewrite = &envoy_type_matcher_v3.RegexMatchAndSubstitute{
Pattern: &envoy_type_matcher_v3.RegexMatcher{
Regex: "^" + httpRoute.PathMatch.Prefix,
},
Substitution: "",
}It does not handle the case where the entire path is removed. In this case we must set the URI to /. Please see https://www.rfc-editor.org/rfc/rfc9112.html#section-3.2.1-2.
If the target URI's path component is empty, the client MUST send "/" as the path within the origin-form of request-target.
If I have a RegexRewrite like:
regexRewrite:
pattern:
regex: ^/foo
substitution: ""I will get 502 when accessing /foo
I will probably send a patch to cilium to fix that
howardjohn
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Fixes #47153
We can use
RegexRewriteto implement this