Fix typo where request.method is request.path #498
Conversation
There is a similar problem in the docs.
|
Hi @hubt. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hubt Assign the PR to them by writing No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
| @@ -11,7 +11,7 @@ rules: | |||
| source: source.labels["app"] | "unknown" | |||
| target: target.service | "unknown" | |||
| service: target.labels["app"] | "unknown" | |||
| method: request.path | "unknown" | |||
| method: request.method | "unknown" | |||
There was a problem hiding this comment.
this was intentional -- method is just a bit overloaded. (it was meant to get at the API method of the service /ratings v. the http method GET). But I have no strong feelings on the need for it either way.
|
Should we close this ? |
|
/test all |
3 similar comments
|
/test all |
|
/test all |
|
/test all |
|
closing but reopen if I'm reading this wrong |
* Reproducing the loop-back auth error. * Add CA. * Small fixes. * Small fixes.
Signed-off-by: Narsing Metpally <nmetpally@axon.com>
There is a similar problem in the docs.