Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix injection in OpenShift #49969

Closed
wants to merge 1 commit into from

Conversation

jwendell
Copy link
Member

Fallback to single cluster client if multi cluster is not active.

Fallback to single cluster client if multi cluster is not active.
@jwendell jwendell added the release-notes-none Indicates a PR that does not require release notes. label Mar 18, 2024
@jwendell jwendell requested a review from a team as a code owner March 18, 2024 21:43
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2024
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is multicluster not active?

@jwendell
Copy link
Member Author

I keep getting unable to fetch namespace, failed to get client for ""

I'm guessing multicluster is false by default? https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/values.yaml#L449

@jwendell jwendell added the do-not-merge Block automatic merging of a PR. label Mar 19, 2024
@jwendell
Copy link
Member Author

I'm working on adding unit tests for this, but it might take a couple of days, can we merge this fix now and add UT later?

@howardjohn
Copy link
Member

I keep getting unable to fetch namespace, failed to get client for ""

I'm guessing multicluster is false by default? https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/values.yaml#L449

I feel like this should work. Maybe we need to make a lookup for "" to be the config cluster.

Either this issue impacts all of the multicluster components or none of them I would think; a fix localized to injection feels likely to be wrong/incomplete

@jwendell
Copy link
Member Author

@howardjohn another approach: #49986

I'll add unit tests for openshift in a separate PR

@jwendell jwendell closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Block automatic merging of a PR. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants