Update istio integration tests to account for removal of cacert field from config dump #50043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from config dump
istio-testing
added
the
size/S
MorrisLaw
requested review from
costinm,
linsun,
howardjohn,
stevenctl,
ericvn and
hzxuzhonghu
as code owners
MorrisLaw
added
the
release-notes-none
|
/retest |
|
Looks like the issue is the secret dump formatter is not matching the golden file. |
howardjohn
approved these changes
Mar 21, 2024
hanxiaop
approved these changes
Mar 22, 2024
istio-testing
added
size/M
Merged
jmcshane
pushed a commit
to superorbital/istio
that referenced
this pull request
Apr 3, 2024
… from config dump (istio#50043) * Update istio integration tests to account for removal of ca_crt field from config dump * use the latest ztunnel master sha * update secret printing and testdata file to have no ca_cert field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
This PR addresses the istio integration failures noticed here: #49964 (comment)
This was a result of the recent changes to migrate to rustls where a struct was modified in ztunnel and removed a field (ca_cert) that gets checked for an istio integration test called TestIntermediateCertRefresh.
Here is the struct in it's current state:
instead of:
This failure is preventing ztunnel from getting updated in istio.deps because the integration tests are failing. This should address the issue by pointing to the ca cert that resides in the cert chain as opposed to pointing to a field that no longer exists in this updated CertsDump struct.