Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automator: update go-control-plane in istio/istio@master #50065

Conversation

istio-testing
Copy link
Collaborator

Generated by Automator - 2024-03-24T02:00:26+00:00

@istio-testing istio-testing requested a review from a team as a code owner March 24, 2024 02:06
@istio-testing istio-testing added auto-merge Set this label on a PR to auto-merge it on success of presubmit tests release-notes-none Indicates a PR that does not require release notes. labels Mar 24, 2024
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 24, 2024
@ericvn
Copy link
Contributor

ericvn commented Mar 25, 2024

/retest

@istio-testing
Copy link
Collaborator Author

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests-arm64_istio 6e04e9a link true /test unit-tests-arm64
unit-tests_istio 6e04e9a link true /test unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn
Copy link
Contributor

ericvn commented Mar 25, 2024

grpcgen_test.go:185: Error in resolve no matching virtual host found for ""}

I note an update in the github.com/grpc/grpc-go update also included in this PR which has a noted change xds: fix a bug that results in no matching virtual host found RPC errors due to a difference between the target and LDS resource names

grpc/grpc-go#6997 seems to move from using:

	endpoint := target.URL.Path
	if endpoint == "" {
		endpoint = target.URL.Opaque
	}
	endpoint = strings.TrimPrefix(endpoint, "/")

to using

target.Endpoint()

Requires a change in https://github.com/istio/istio/blob/master/pilot/pkg/networking/grpcgen/grpcgen_test.go#L172-L174 or a regression in grpc-go?

@ericvn
Copy link
Contributor

ericvn commented Mar 27, 2024

Likely superseded by #50129

@ericvn ericvn closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Set this label on a PR to auto-merge it on success of presubmit tests release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants