Update testInfo.go #502
Merged
Update testInfo.go #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastienvas: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Jenkins job istio/presubmit passed |
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
* Introduce preprocess step into the mixer dispatch. This PR adds a Preprocess() method to the AspectDispatcher. This method (and the associated logic used to invoke it before other mixer dispatch for Check, Report, and Quota) will be used to execute Aspects that must preceed all further processing. Example uses include: environment-specific attribute generation and identity-related tasks. Attributes generated in preprocess step will be merged back in with the original request bags and passed to the existing dispatch methods. Currently, there are no existing Aspects that are associated with the preprocess step (as a result, it acts as simple pass through). A new aspect kind was added, primarily for testing purposes. However, it is expected that that aspect will be used in follow-on PRs. Note: it is expected that the preprocess aspects will behave and be configured in the exact same manner as other aspects. However, in subsequent PRs, we may want to limit restrict the ability to configure some of these aspects to only be globally-configurable to prevent possibly conflicts between selectors and the attributes they depend on. More thinking is needed here. For now, this potential problem is left alone. * Add ResolveUnconditional to Resolver interface. This adds a ResolveUnconditional method to get around issues with multiple calls to Resolve potentially introduced by Preprocess. This will allow configuration of Preprocess aspects in ServiceConfig, as long as that configuration is unconditional (has a selector of ""). This allows introduction of attribute generation adapters in a manner consistent with the rest of the adapter subsystems (does not require API changes, etc.). Former-commit-id: efaac34fc2b79dfa90647c2c6c759b1f9815f52c
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Introduce preprocess step into the mixer dispatch. This PR adds a Preprocess() method to the AspectDispatcher. This method (and the associated logic used to invoke it before other mixer dispatch for Check, Report, and Quota) will be used to execute Aspects that must preceed all further processing. Example uses include: environment-specific attribute generation and identity-related tasks. Attributes generated in preprocess step will be merged back in with the original request bags and passed to the existing dispatch methods. Currently, there are no existing Aspects that are associated with the preprocess step (as a result, it acts as simple pass through). A new aspect kind was added, primarily for testing purposes. However, it is expected that that aspect will be used in follow-on PRs. Note: it is expected that the preprocess aspects will behave and be configured in the exact same manner as other aspects. However, in subsequent PRs, we may want to limit restrict the ability to configure some of these aspects to only be globally-configurable to prevent possibly conflicts between selectors and the attributes they depend on. More thinking is needed here. For now, this potential problem is left alone. * Add ResolveUnconditional to Resolver interface. This adds a ResolveUnconditional method to get around issues with multiple calls to Resolve potentially introduced by Preprocess. This will allow configuration of Preprocess aspects in ServiceConfig, as long as that configuration is unconditional (has a selector of ""). This allows introduction of attribute generation adapters in a manner consistent with the rest of the adapter subsystems (does not require API changes, etc.). Former-commit-id: 685455cc638473da2b0442e6f69d5356cbca45ec
vbatts
pushed a commit
to vbatts/istio
that referenced
this pull request
Oct 31, 2017
Former-commit-id: f0d452d
guptasu
pushed a commit
to guptasu/istio
that referenced
this pull request
Jun 11, 2018
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* automtls aspect in the enable mesh tls. * make gen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.