Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependa bot 1.18 branch config #50482

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

hzxuzhonghu
Copy link
Member

@hzxuzhonghu hzxuzhonghu commented Apr 16, 2024

Please provide a description of this PR:

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2024
@hzxuzhonghu hzxuzhonghu changed the title remove 1.18 branch config remove dependa bot 1.18 branch config Apr 16, 2024
Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change originally went in with PR #45598. I have not seen any action on the 1.18 branch caused by this. I believe, but couldn't find information on security updates are only against the default branch, so this would tend to make sense.

Approving this removal since I haven't seen it have an effect.

Note the doc page also has: Use target-branch to specify a different branch for manifest files and for pull requests. When you use this option, the settings for this package manager will no longer affect any pull requests raised for security updates.

@ericvn ericvn added the release-notes-none Indicates a PR that does not require release notes. label Apr 16, 2024
@ericvn
Copy link
Contributor

ericvn commented Apr 16, 2024

/test release-notes

@istio-testing istio-testing merged commit 61b89f6 into istio:master Apr 16, 2024
28 checks passed
@hzxuzhonghu hzxuzhonghu deleted the rm-dependabot-1.18 branch April 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants