remove max drain duration #50508
Merged
remove max drain duration #50508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-policy-bot
added
the
release-notes-none
istio-testing
added
the
size/XS
hzxuzhonghu
reviewed
Apr 17, 2024
| @@ -1390,10 +1390,6 @@ func ValidateDrainDuration(drainTime *durationpb.Duration) (errs error) { | |||
| errors.New("drain time only supports durations to seconds precision")) | |||
| } | |||
|
|
|||
| if drainDuration > drainTimeMax { | |||
There was a problem hiding this comment.
Why it was there?
If remove, drainTimeMax should be removed too
There was a problem hiding this comment.
Do not the know the history. But seems not needed. Removed the var also
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
added
size/S
|
/test integ-security |
howardjohn
approved these changes
Apr 17, 2024
Same here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some protocols needs more drain duration it seems #50477. Envoy does not have max - So not sure if we should have one