Push some local test cleanups #50653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-policy-bot
added
area/test and release
release-notes-none
istio-testing
added
the
size/XL
bleggett
force-pushed
the
bleggett/test-cleanups
branch
2 times, most recently
from
a66e6d7
to
431d5ca
Compare
howardjohn
approved these changes
Apr 23, 2024
lei-tang
approved these changes
Apr 23, 2024
bleggett
force-pushed
the
bleggett/test-cleanups
branch
2 times, most recently
from
09e950f
to
b07dc64
Compare
|
/test integ-security-multicluster |
1 similar comment
|
/test integ-security-multicluster |
I don't think it's a flake, I just dorked something. Fixing. |
|
/retest |
bleggett
force-pushed
the
bleggett/test-cleanups
branch
2 times, most recently
from
b237453
to
8112c08
Compare
istio-testing
added
the
needs-rebase
bleggett
force-pushed
the
bleggett/test-cleanups
branch
from
8112c08
to
57ee6a4
Compare
istio-testing
added
needs-rebase
bleggett
force-pushed
the
bleggett/test-cleanups
branch
2 times, most recently
from
e45e56a
to
146ef71
Compare
istio-testing
removed
the
needs-rebase
bleggett
force-pushed
the
bleggett/test-cleanups
branch
from
7d396fd
to
839ab33
Compare
bleggett
force-pushed
the
bleggett/test-cleanups
branch
from
839ab33
to
ce49591
Compare
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/test-cleanups
branch
from
ce49591
to
bed0fe8
Compare
|
/test unit-tests-arm64 |
bleggett
added a commit
to bleggett/istio
that referenced
this pull request
May 3, 2024
* Use `Label` suffixes Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Tidy test annotation handling Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Lints Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> --------- Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
added a commit
to bleggett/istio
that referenced
this pull request
May 3, 2024
* Use `Label` suffixes Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Tidy test annotation handling Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Lints Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> --------- Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
istio-testing
pushed a commit
that referenced
this pull request
May 4, 2024
…el ambient opt-out (#50850) * Push some local test cleanups (#50653) * Use `Label` suffixes Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Tidy test annotation handling Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Lints Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> --------- Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Use label istio.io/dataplane-mode=disabled for pod-level ambient opt-out (#50804) * Use label for opt-out Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Resync with master Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Fix tests Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> * Remove comment Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> --------- Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io> --------- Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Follow-on fixes from #50572
Annotationindirection/aliasing used in test code that actually made refactoring + discovery harder, in favor of ye oldemap[string]string