Update README about flags on cluster logs #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyliu513
reviewed
Aug 9, 2017
tests/e2e/README.md
Outdated
| @@ -19,6 +19,8 @@ Tests could be built and drove manually as a single test or automatically detect | |||
| * `--verbose` debug level noise from proxies | |||
| * `--istioctl_url` the location of an `istioctl` binary | |||
| * `--skip_cleanup` if skip cleanup steps | |||
| * `--log_provider` where cluster logs are hosted, only support stackdriver for now | |||
There was a problem hiding this comment.
how about s/stackdriver/stackdriver
|
/assign @sebastienvas |
sebastienvas
approved these changes
Aug 9, 2017
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chxchx, sebastienvas Associated issue requirement bypassed by: sebastienvas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
* Add rolling-window for rate limiting. * Address comments. * Update comment. Former-commit-id: 961ec5e317066b8300fe836f105cb1f8d335d9b2
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
Automatic merge from submit-queue Update README about flags on cluster logs **Release note**: ```release-note NONE ``` Former-commit-id: 93a124b
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Add rolling-window for rate limiting. * Address comments. * Update comment. Former-commit-id: cbdf7f3697d410f9f02e7435ea2d686c36321374
vbatts
pushed a commit
to vbatts/istio
that referenced
this pull request
Oct 31, 2017
Automatic merge from submit-queue Update README about flags on cluster logs **Release note**: ```release-note NONE ``` Former-commit-id: 93a124b
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
Automatic merge from submit-queue Update README about flags on cluster logs **Release note**: ```release-note NONE ``` Former-commit-id: 93a124b
rshriram
pushed a commit
to rshriram/istio
that referenced
this pull request
Jul 31, 2018
* add enable_sds flag to MeshConfig proto definition * address comments - 1. update boolean(sds_enable) to string(uds path) 2. add sds_refresh_delay field * address comment
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
luksa
added a commit
to luksa/istio
that referenced
this pull request
Sep 15, 2022
…stio#263) (istio#547) This adds an option to istiod that allows disabling reading IngressClass resources, which are cluster-scoped. When this is disabled, processing of Ingress resources that use the new (as of Kubernetes v1.18) `ingressClassName` field in their spec is not supported. Only resources that use the deprecated annotation will be processed. Co-authored-by: Marko Lukša <marko.luksa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: