Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #554

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Fix typo #554

merged 1 commit into from
Aug 15, 2017

Conversation

danmcp
Copy link
Contributor

@danmcp danmcp commented Aug 11, 2017

Release note:

@istio-testing
Copy link
Collaborator

Hi @danmcp. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher
Copy link
Contributor

/approve no-issue
/release-note-none
/lgtm

Copy link
Contributor

@ZackButcher ZackButcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think we still have to manually approve on this repo.

@ZackButcher
Copy link
Contributor

/assign @geeknoid

Copy link
Contributor

@geeknoid geeknoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve no-issue

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZackButcher, danmcp, geeknoid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yutongz
Copy link
Contributor

yutongz commented Aug 14, 2017

/test all

@yutongz
Copy link
Contributor

yutongz commented Aug 15, 2017

/ok-to-test

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 0a85223 into istio:master Aug 15, 2017
rshriram pushed a commit that referenced this pull request Oct 30, 2017
Automatic merge from submit-queue

Fix typo

**Release note**:

```release-note
```

Former-commit-id: 0a85223
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
Automatic merge from submit-queue

Fix typo

**Release note**:

```release-note
```

Former-commit-id: 0a85223
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
Automatic merge from submit-queue

Fix typo

**Release note**:

```release-note
```

Former-commit-id: 0a85223
howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
* Remove gen

* Fix noauth

* run build

* Fix ingress

* final fixes and gitignore

* Deflake noauth

* Fix noauth
luksa pushed a commit to luksa/istio that referenced this pull request Sep 20, 2022
…yz (istio#554)

Signed-off-by: rcernich <rcernich@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants