Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation yamls #555

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Update installation yamls #555

merged 1 commit into from
Aug 11, 2017

Conversation

kyessenov
Copy link
Contributor

Release note:

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kyessenov
We suggest the following additional approver: ldemailly

Assign the PR to them by writing /assign @ldemailly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@kyessenov
Copy link
Contributor Author

This is needed to pass https://github.com/istio/pilot/pull/1019/files

@kyessenov
Copy link
Contributor Author

/assign @ldemailly

Copy link
Contributor

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dogscience

@kyessenov kyessenov merged commit 2c17af4 into istio:master Aug 11, 2017
@kyessenov kyessenov deleted the proxy_name branch August 11, 2017 19:27
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
Former-commit-id: ed7e952ad28d0891ee31f626b4e0fba49ed3f262
rshriram pushed a commit that referenced this pull request Oct 30, 2017
Former-commit-id: 2c17af4
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
Former-commit-id: 565c987b96b54154adbf6b6e09c4441a88242676
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
Former-commit-id: 2c17af4
rshriram pushed a commit to rshriram/istio that referenced this pull request Jul 31, 2018
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
* Moving the stdout output to l.logAndError(), also change a logAndOutput into l.logAndError().

* Also improve the output from kube client.
luksa pushed a commit to luksa/istio that referenced this pull request Sep 15, 2022
…tryz (istio#555)

Signed-off-by: rcernich <rcernich@redhat.com>
luksa pushed a commit to luksa/istio that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants