Create artifacts to given directory #581
Conversation
|
/assign @rshriram |
release/create_release_archives.sh
Outdated
| TMP_DIR="$(mktemp -d /tmp/istio.version.XXXX)" | ||
| COMMON_FILES_DIR="${TMP_DIR}/istio/istio-${ISTIO_VERSION}" | ||
| ARCHIVES_DIR="${TMP_DIR}/archives" | ||
| BASE_DIR="$(mktemp -d /tmp/istio.version.XXXX)" |
There was a problem hiding this comment.
Here you are creating a temp dir. You should created it only if value is not net. ie
BASE_DIR=
There was a problem hiding this comment.
Indeed. I overlooked the fact that a directory is actually created besides returning a path. Good catch.
| d) BASE_DIR="${OPTARG}";; | ||
| esac | ||
| done | ||
|
|
There was a problem hiding this comment.
Here you would add
[[ -z
|
PTAL |
|
/lgtm |
|
/assign @rshriram |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshriram, sebastienvas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
@chxchx: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Add an adapter that implements every aspect but does no work. * Add in an empty params proto so we don't run into issues returning nil * Dump the empty params proto in favor of using proto.Empty. Add a test for verifying that the no-op adapter is registered for every aspect kind. * Return a failed precondition in the noop Deny aspect impl. Former-commit-id: 7ff9e1a200b431da305c89833773e825623bea8a
Automatic merge from submit-queue Create artifacts to given directory Add a new flag to `release/create_release_archives.sh` so tar files are made in the given directory, which makes release automation easier as per istio/test-infra#393 **Release note**: ```release-note None ``` Former-commit-id: 85326e0
* Add an adapter that implements every aspect but does no work. * Add in an empty params proto so we don't run into issues returning nil * Dump the empty params proto in favor of using proto.Empty. Add a test for verifying that the no-op adapter is registered for every aspect kind. * Return a failed precondition in the noop Deny aspect impl. Former-commit-id: d3b78618a13a69cdea71066f9f5f817afb4e74e8
Automatic merge from submit-queue Create artifacts to given directory Add a new flag to `release/create_release_archives.sh` so tar files are made in the given directory, which makes release automation easier as per istio/test-infra#393 **Release note**: ```release-note None ``` Former-commit-id: 85326e0
* validate proxy mesh config * add auth policy validation * simplify linter * add host validation
Automatic merge from submit-queue Create artifacts to given directory Add a new flag to `release/create_release_archives.sh` so tar files are made in the given directory, which makes release automation easier as per istio/test-infra#393 **Release note**: ```release-note None ``` Former-commit-id: 85326e0
Add a new flag to
release/create_release_archives.shso tar files are made in the given directory, which makes release automation easier as per istio/test-infra#393Release note: