Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail test if there is not _bazel_bootstrap #583

Merged
merged 3 commits into from
Aug 23, 2017

Conversation

yutongz
Copy link
Contributor

@yutongz yutongz commented Aug 18, 2017

Release note:

None

Workaround fix istio/test-infra#396

@yutongz
Copy link
Contributor Author

yutongz commented Aug 18, 2017

@sebastienvas

@yutongz
Copy link
Contributor Author

yutongz commented Aug 19, 2017

/test all

1 similar comment
@yutongz
Copy link
Contributor Author

yutongz commented Aug 20, 2017

/test all

Copy link
Contributor

@sebastienvas sebastienvas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is happening when we run the bazel query on tests/e2e.sh. I would update that file instead of those 2:
TESTS_TARGETS=($(bazel query 'tests(//tests/e2e/tests/...)')) || error_exit 'Could not find targets'

@sebastienvas
Copy link
Contributor

/lgtm
/approve

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebastienvas

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 172957a into istio:master Aug 23, 2017
@istio-testing
Copy link
Collaborator

@yutongz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-no_rbac-auth.sh 1d3f59b link /test e2e-suite-no_rbac-auth
prow/e2e-suite-rbac-auth.sh 1d3f59b link /test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yutongz yutongz deleted the check_cache_dir branch August 27, 2017 09:38
rshriram pushed a commit that referenced this pull request Oct 30, 2017
Automatic merge from submit-queue

Fail test if there is not _bazel_bootstrap

**Release note**:

```release-note
None
```

Workaround fix  istio/test-infra#396

Former-commit-id: 172957a
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
Automatic merge from submit-queue

Fail test if there is not _bazel_bootstrap

**Release note**:

```release-note
None
```

Workaround fix  istio/test-infra#396

Former-commit-id: 172957a
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
Automatic merge from submit-queue

Fail test if there is not _bazel_bootstrap

**Release note**:

```release-note
None
```

Workaround fix  istio/test-infra#396

Former-commit-id: 172957a
rshriram pushed a commit to rshriram/istio that referenced this pull request Jul 31, 2018
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prow failed to create _bazel_bootstrap dir
5 participants