Removed '()' for ISTIO variable. #586
Conversation
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshriram The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
Automatic merge from submit-queue |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
@gyliu513: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -228,7 +228,7 @@ reviews much easier. | |||
| Using Mixer as an example: | |||
|
|
|||
| ```shell | |||
| cd $(ISTIO)/mixer | |||
| cd $ISTIO/mixer | |||
There was a problem hiding this comment.
What difference does it make?
There was a problem hiding this comment.
root@k8s001:~# export ISTIO=/root/go/src/istio.io/
root@k8s001:~# echo $ISTIO
/root/go/src/istio.io/
root@k8s001:~# echo $(ISTIO)
ISTIO: command not found
ISTIO is not a command and we cannot add () for it. @ldemailly
There was a problem hiding this comment.
oh right it should have been ${ISTIO} or $ISTIO indeed ($(ISTIO) is in Makefiles)
thanks for having fixed it
Former-commit-id: f6a38347a14e1390caa3f1540596bf3736af54c9
Automatic merge from submit-queue Removed '()' for ISTIO variable. **Release note**: ```release-note None ``` /cc @ldemailly Former-commit-id: 9b8fb3f
Former-commit-id: c959b0090efb8ba1ce546b7702c9decc0bfecb9c
Automatic merge from submit-queue Removed '()' for ISTIO variable. **Release note**: ```release-note None ``` /cc @ldemailly Former-commit-id: 9b8fb3f
Automatic merge from submit-queue Removed '()' for ISTIO variable. **Release note**: ```release-note None ``` /cc @ldemailly Former-commit-id: 9b8fb3f
Automatic merge from submit-queue [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
* Installation option doc cleanup * regen
Release note:
/cc @ldemailly