Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated devel readme use make target. #589

Merged
merged 1 commit into from
Aug 26, 2017
Merged

Updated devel readme use make target. #589

merged 1 commit into from
Aug 26, 2017

Conversation

gyliu513
Copy link
Member

Release note:

None

@gyliu513
Copy link
Member Author

/retest

@ldemailly
Copy link
Contributor

I'm not 100% convinced of the value added here ?

@gyliu513
Copy link
Member Author

Using make seems more simple as we already wrapped the command in a Makefile.

@rshriram
Copy link
Member

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rshriram

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 81e1e0f into istio:master Aug 26, 2017
@istio-testing
Copy link
Collaborator

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-auth.sh ef59fed link /test e2e-suite-rbac-auth
prow/e2e-suite-no_rbac-auth.sh ef59fed link /test e2e-suite-no_rbac-auth
prow/e2e-suite-rbac-no_auth.sh ef59fed link /test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513 gyliu513 deleted the make branch August 27, 2017 03:52
rshriram pushed a commit that referenced this pull request Oct 30, 2017
@gyliu513 @istio-merge-robot
Updated devel readme use make target. (#589)
e7a4d35 
Automatic merge from submit-queue

Updated devel readme use `make target`.

**Release note**:

```release-note
None
```

Former-commit-id: 81e1e0f
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
@gyliu513 @istio-merge-robot
Updated devel readme use make target. (istio#589)
8d00293 
Automatic merge from submit-queue

Updated devel readme use `make target`.

**Release note**:

```release-note
None
```

Former-commit-id: 81e1e0f
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@gyliu513 @istio-merge-robot
Updated devel readme use make target. (#589)
a487260 
Automatic merge from submit-queue

Updated devel readme use `make target`.

**Release note**:

```release-note
None
```

Former-commit-id: 81e1e0f
rshriram pushed a commit to rshriram/istio that referenced this pull request Jul 31, 2018
@liminw @geeknoid
Add $location marker for authentication policy proto (istio#589)
d64ee58
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
@istio-merge-robot
Update_Dependencies (istio#589)
1509b93 
Automatic merge from submit-queue

[DO NOT MERGE] Auto PR to update dependencies of proxy

This PR will be merged automatically once checks are successful.
```release-note
none
```
howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@howardjohn @istio-testing
Add protocol detection timeout to mesh config (istio#589)
46d995f 
This copies from istio/istio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshriram rshriram rshriram approved these changes

Assignees

@rshriram rshriram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gyliu513 @ldemailly @rshriram @istio-merge-robot @istio-testing @googlebot