-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documenting that golang-go is needed to build proxy #592
Conversation
test ```release-note none ```
/approve no-issue |
/retest all |
/test all |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
@ldemailly you also need to approve using the github button since in this repo, that is still a requirement, although we should probably should make it not required to block auto-merge. cc @sebastienvas |
/lgtm cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andraxylia, gyliu513, ldemailly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
@ldemailly: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue documenting that golang-go is needed to build proxy Until https://github.com/istio/proxy/issues/424 is fixed, we need go installed ```release-note none ``` Former-commit-id: 2405c74
Automatic merge from submit-queue documenting that golang-go is needed to build proxy Until https://github.com/istio/proxy/issues/424 is fixed, we need go installed ```release-note none ``` Former-commit-id: 2405c74
Automatic merge from submit-queue documenting that golang-go is needed to build proxy Until https://github.com/istio/proxy/issues/424 is fixed, we need go installed ```release-note none ``` Former-commit-id: 2405c74
Automatic merge from submit-queue [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
Until https://github.com/istio/proxy/issues/424 is fixed, we need go installed