Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documenting that golang-go is needed to build proxy #592

Merged
merged 4 commits into from
Aug 26, 2017

Conversation

ldemailly
Copy link
Contributor

@ldemailly ldemailly commented Aug 22, 2017

Until https://github.com/istio/proxy/issues/424 is fixed, we need go installed

none

test
```release-note
none
```
@ldemailly
Copy link
Contributor Author

/approve no-issue

@ldemailly ldemailly changed the title test do not merge adding new dependency (golang-go) Aug 23, 2017
@ldemailly ldemailly self-assigned this Aug 23, 2017
@ldemailly ldemailly added this to the Istio 0.2 milestone Aug 23, 2017
@ldemailly ldemailly changed the title adding new dependency (golang-go) documenting that golang-go is needed to build proxy Aug 23, 2017
@ldemailly
Copy link
Contributor Author

/retest all

@yutongz
Copy link
Contributor

yutongz commented Aug 23, 2017

/test all

@yutongz
Copy link
Contributor

yutongz commented Aug 25, 2017

/test all

Copy link
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yutongz
Copy link
Contributor

yutongz commented Aug 25, 2017

/lgtm

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@yutongz
Copy link
Contributor

yutongz commented Aug 25, 2017

@ldemailly you also need to approve using the github button since in this repo, that is still a requirement, although we should probably should make it not required to block auto-merge. cc @sebastienvas

@yutongz
Copy link
Contributor

yutongz commented Aug 25, 2017

/lgtm cancel
Stop bot from keep testing and trying to merge which obviously will not work. Add it back when we have github approval.

@andraxylia
Copy link
Contributor

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia, gyliu513, ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [andraxylia,ldemailly]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 2405c74 into master Aug 26, 2017
@ldemailly ldemailly deleted the ldemailly-patch-1 branch August 26, 2017 02:23
@istio-testing
Copy link
Collaborator

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-auth.sh d6cfdc5 link /test e2e-suite-rbac-auth
prow/e2e-suite-no_rbac-auth.sh d6cfdc5 link /test e2e-suite-no_rbac-auth
prow/e2e-suite-rbac-no_auth.sh d6cfdc5 link /test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rshriram pushed a commit that referenced this pull request Oct 30, 2017
Automatic merge from submit-queue

documenting that golang-go is needed to build proxy

Until https://github.com/istio/proxy/issues/424 is fixed, we need go installed

```release-note
none
```

Former-commit-id: 2405c74
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
Automatic merge from submit-queue

documenting that golang-go is needed to build proxy

Until https://github.com/istio/proxy/issues/424 is fixed, we need go installed

```release-note
none
```

Former-commit-id: 2405c74
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
Automatic merge from submit-queue

documenting that golang-go is needed to build proxy

Until https://github.com/istio/proxy/issues/424 is fixed, we need go installed

```release-note
none
```

Former-commit-id: 2405c74
rshriram pushed a commit to rshriram/istio that referenced this pull request Jul 31, 2018
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
Automatic merge from submit-queue

[DO NOT MERGE] Auto PR to update dependencies of proxy

This PR will be merged automatically once checks are successful.
```release-note
none
```
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants