Update readme about new automated release process #595

chxchx · 2017-08-23T20:58:03Z

Release note:

None

chxchx · 2017-08-23T21:00:22Z

/assign @sebastienvas
/assign @rvkubiak
/assign @geeknoid
PTAL

sebastienvas · 2017-08-23T23:53:49Z

release/README.md

-## Creating tags
+## Semi-automated Release Since 0.2
+
+Release from 0.2 onward is semi automated. It is still driven from a release engineer desktop but all actions are automated using [githubctl](https://github.com/istio/test-infra/blob/master/toolbox/githubctl/main.go), a tool of our own that acts as a github client making REST calls through the github API. The release process goes like the following:


Could you also document how to get githubctl and build it. ie
git clone test-infra
bazel build ..
alias githubctl ${PWD/bazel-bin.....

sebastienvas · 2017-08-23T23:54:50Z

release/README.md

+    --base_branch=<release branch or master>
+
+# The previous command triggers rebuild and retagging on pilot, mixer and auth.
+# Wait for them to finish, then create an update PR in istio/istio


@rvkubiak We'll need to have a public link for this. Is this possible ?

Eventually artifacts from pilot, mixer and auth are available through the release on github, so maybe a public link at this step is not necessary?

Sorry for the confusion. For people that don't have access to the GCP project where GCB is setup, we need to know when artifacts are created such that we can proceed.

sebastienvas · 2017-08-23T23:55:51Z

release/README.md

+
+# The previous command triggers rebuild and retagging on pilot, mixer and auth.
+# Wait for them to finish, then create an update PR in istio/istio
+$ githubctl --token_file=<github token file> \


Actually does the tool logs the PR created, it would be good to also know which PR we are waiting for here.

Yes it does. At the end of console output, it will say something like

2017/08/22 00:03:18 Created new PR at https://github.com/istio/istio/pull/588

sebastienvas

Minor edits

chxchx · 2017-08-24T01:02:11Z

PTAL

sebastienvas · 2017-08-24T04:02:15Z

/lgtm

sebastienvas · 2017-08-24T04:02:23Z

/retest

geeknoid · 2017-08-24T13:39:38Z

release/README.md


 If you are making a release from a branch, use the branch name, e.g. `BRANCH=release-0.1` for 0.1 or `master` for master.

-## Creating tags
+## Semi-automated Release Since 0.2


Release Since -> release since

geeknoid · 2017-08-24T13:40:13Z

release/README.md

-## Creating tags
+## Semi-automated Release Since 0.2
+
+Release from 0.2 onward is semi-automated. It is still driven from a release engineer desktop but all actions are automated using [githubctl](https://github.com/istio/test-infra/blob/master/toolbox/githubctl/main.go), a tool of our own that acts as a github client making REST calls through the github API. One may get githubctl from the istio/test-infra repository  


The release process is semi-automated starting with release 0.2.

github -> GitHub

Please wrap lines so they aren't longer than ~100 chars or so.

geeknoid · 2017-08-24T13:42:09Z

release/README.md

+$ githubctl --token_file=<github token file> \
+    --op=updateIstioVersion --base_branch=<release branch or master> 
+
+# Wait for the PR to merged.


to be merged

geeknoid · 2017-08-24T13:42:24Z

release/README.md

+    --op=updateIstioVersion --base_branch=<release branch or master> 
+
+# Wait for the PR to merged.
+# Then create the release in github, upload the artifacts,


geeknoid · 2017-08-24T13:43:07Z

release/README.md

+    --next_release=0.2.2
+```
+
+## Manual Release Process


Manual release process

geeknoid · 2017-08-24T13:43:27Z

release/README.md

@@ -59,7 +97,7 @@ Fortunately each tag above contains the short SHA at which it was built.
        $ git tag -a ${RELEASE_TAG} -m "Istio Release ${RELEASE_TAG}" ${AUTH_SHA}
        $ git push --tags origin

-## Rebuild Artifacts to include the tags
+### Rebuild Artifacts to include the tags


Artifacts -> artifacts

geeknoid · 2017-08-24T13:45:35Z

release/README.md

@@ -12,11 +12,49 @@ Istio release is currently composed of artifacts for the following repos:

 The release consists in retagging the artifacts and creating new annotated tags.


This document deserves a table of contents. See istio/istio/README.md for an example TOC format.

istio-merge-robot · 2017-08-24T21:56:50Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @chxchx @sebastienvas

chxchx · 2017-08-24T21:57:46Z

@geeknoid PTAL

istio-testing · 2017-08-24T22:52:24Z

@chxchx: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/e2e-suite-rbac-no_auth.sh	`1ad97af`	link	`/test e2e-suite-rbac-no_auth`
prow/e2e-suite-rbac-auth.sh	`1ad97af`	link	`/test e2e-suite-rbac-auth`
prow/e2e-suite-no_rbac-auth.sh	`1ad97af`	link	`/test e2e-suite-no_rbac-auth`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

chxchx · 2017-08-24T23:18:38Z

@sebastienvas The LGTM label was removed due to another commit by me. Would you mind adding it again? Thanks!

sebastienvas · 2017-08-24T23:35:43Z

/lgtm

istio-merge-robot · 2017-08-24T23:35:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebastienvas
We suggest the following additional approver: geeknoid

Assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Former-commit-id: 1e9e580cc6d173ca1326ad7c4aaef0230a58644c

* Update readme aboutnew release process * Explain how to get and use githubctl * Table of content, formatting and wording Former-commit-id: 857f64e

Former-commit-id: df73d504407ebbad28ea3b48272adaeaafdc7094

* Update readme aboutnew release process * Explain how to get and use githubctl * Table of content, formatting and wording Former-commit-id: 857f64e

* Add gdb, curl and vim to debug image to chase envoy crashes * Add emacs and nano * Remove one extra curl

* Update readme aboutnew release process * Explain how to get and use githubctl * Table of content, formatting and wording Former-commit-id: 857f64e

* Add quota config parser * Rename to EmptyMatch * Not to return true for default case * Revert "Not to return true for default case" This reverts commit 855bf434621668a740bc4bf03f76a371564560df. * Ignore not_set and regex * Add regex support . * update comment

Update readme aboutnew release process

1ecfb6b

googlebot added the cla: yes label Aug 23, 2017

istio-merge-robot added the release-note-none label Aug 23, 2017

sebastienvas reviewed Aug 23, 2017

View reviewed changes

sebastienvas suggested changes Aug 23, 2017

View reviewed changes

Explain how to get and use githubctl

d2e54e2

sebastienvas approved these changes Aug 24, 2017

View reviewed changes

istio-testing assigned sebastienvas Aug 24, 2017

istio-testing added the lgtm label Aug 24, 2017

geeknoid reviewed Aug 24, 2017

View reviewed changes

Table of content, formatting and wording

47094a5

istio-merge-robot removed the lgtm label Aug 24, 2017

Merge branch 'master' into releaseDoc

1ad97af

geeknoid approved these changes Aug 24, 2017

View reviewed changes

istio-testing added the lgtm label Aug 24, 2017

sebastienvas merged commit 857f64e into istio:master Aug 24, 2017

mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017

Remove inputs indirection in listchecker (istio#595)

48e7f40

Former-commit-id: 1e9e580cc6d173ca1326ad7c4aaef0230a58644c

rshriram pushed a commit that referenced this pull request Oct 30, 2017

Update readme about new automated release process (#595)

630d03b

* Update readme aboutnew release process * Explain how to get and use githubctl * Table of content, formatting and wording Former-commit-id: 857f64e

mandarjog pushed a commit that referenced this pull request Oct 31, 2017

Remove inputs indirection in listchecker (#595)

5936569

Former-commit-id: df73d504407ebbad28ea3b48272adaeaafdc7094

mandarjog pushed a commit that referenced this pull request Oct 31, 2017

Add gdb, curl and vim to debug image to chase envoy crashes (#595)

58ceb2f

* Add gdb, curl and vim to debug image to chase envoy crashes * Add emacs and nano * Remove one extra curl

mandarjog pushed a commit that referenced this pull request Nov 2, 2017

Update readme about new automated release process (#595)

e75ec4b

* Update readme aboutnew release process * Explain how to get and use githubctl * Table of content, formatting and wording Former-commit-id: 857f64e

howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020

Move meshNetworks network1,2 under networks: (istio#595)

e24e82c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update readme about new automated release process #595

Update readme about new automated release process #595

chxchx commented Aug 23, 2017

chxchx commented Aug 23, 2017 •

edited

Loading

sebastienvas Aug 23, 2017

chxchx Aug 24, 2017

sebastienvas Aug 23, 2017

chxchx Aug 24, 2017

sebastienvas Aug 24, 2017

sebastienvas Aug 23, 2017

chxchx Aug 24, 2017

sebastienvas left a comment

chxchx commented Aug 24, 2017

sebastienvas commented Aug 24, 2017

sebastienvas commented Aug 24, 2017

geeknoid Aug 24, 2017

chxchx Aug 24, 2017

geeknoid Aug 24, 2017

geeknoid Aug 24, 2017

geeknoid Aug 24, 2017

chxchx Aug 24, 2017

geeknoid Aug 24, 2017

chxchx Aug 24, 2017

geeknoid Aug 24, 2017

chxchx Aug 24, 2017

geeknoid Aug 24, 2017

chxchx Aug 24, 2017

geeknoid Aug 24, 2017

chxchx Aug 24, 2017

geeknoid Aug 24, 2017

chxchx Aug 24, 2017

istio-merge-robot commented Aug 24, 2017

chxchx commented Aug 24, 2017

istio-testing commented Aug 24, 2017

chxchx commented Aug 24, 2017

sebastienvas commented Aug 24, 2017

istio-merge-robot commented Aug 24, 2017

		@@ -12,11 +12,49 @@ Istio release is currently composed of artifacts for the following repos:

		The release consists in retagging the artifacts and creating new annotated tags.

Update readme about new automated release process #595

Update readme about new automated release process #595

Conversation

chxchx commented Aug 23, 2017

chxchx commented Aug 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebastienvas left a comment

Choose a reason for hiding this comment

chxchx commented Aug 24, 2017

sebastienvas commented Aug 24, 2017

sebastienvas commented Aug 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

istio-merge-robot commented Aug 24, 2017

chxchx commented Aug 24, 2017

istio-testing commented Aug 24, 2017

chxchx commented Aug 24, 2017

sebastienvas commented Aug 24, 2017

istio-merge-robot commented Aug 24, 2017

chxchx commented Aug 23, 2017 •

edited

Loading