WIP: Mitigate overloading stackdriver api until quota increased #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@chxchx: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
…siness. (istio#639) * Update the symbol names for all ConfigErrors to adopt camelCase consistently. * Only log from the dedup repear at a higher logging level to avoid noisiness. Former-commit-id: eb66b0c3d8826cec935ce5a6eec709abdbcdd7c5
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
…siness. (#639) * Update the symbol names for all ConfigErrors to adopt camelCase consistently. * Only log from the dedup repear at a higher logging level to avoid noisiness. Former-commit-id: 8f5bdba213890dc650b62494c08cbc089f5a317e
mandarjog
added a commit
that referenced
this pull request
Oct 31, 2017
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* Fixes for istiod injection Right now there is no way to remove the sidecar injector deployment when using istiod. This means you will always have a bunch of config that is unused. Instead, when istiod is enabled, remove the injector stuff. Alternative approach would be to add an explicit flag for this, like istiod.disableinjector or something, but I am not sure that is needed at this time. Additionally, add back features from the old injection to avoid regressions. These are critical features, not just legacy junk. Finally, reuse the old name for the configmap so existing tooling like istioctl can continue to function correctly. * Fix tests
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* Add unit test and fix for ICP.DeepCopy() DeepCopy() always failed with an error, which was only logged and wasn't handled properly. The error occured when unmarshalling CreatedTimestamp, which meant that all remaining fields were never unmarshalled. * Add copyright header * Update go.mod * Add additional test and fix import formatting
0x01001011
pushed a commit
to thedemodrive/istio
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to increase the stackdriver api quota limit. This is plan b if that does pass.
Release note: