-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Auto PR to update dependencies of istio #663
[DO NOT MERGE] Auto PR to update dependencies of istio #663
Conversation
/lgtm cancel //PR changed after LGTM, removing LGTM. @istio-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
if the tests would pass
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@istio-testing: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Restart sidecar proxy when Istio auth secret is changed * Code refactor * Check returned error * return * hash error * move things into auth.go * Watch certs in Egress * Watch certs from Ingress * renmae from auth.go to cert.go * Add unit test for cert watcher * test hashing * check returned error * address comments
This PR will be merged automatically once checks are successful.