Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Auto PR to update dependencies of istio #663

Closed

Conversation

istio-testing
Copy link
Collaborator

@istio-testing istio-testing commented Sep 4, 2017

This PR will be merged automatically once checks are successful.

@istio-merge-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @istio-testing

Copy link
Contributor

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
if the tests would pass

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly mentioned this pull request Sep 4, 2017
@istio-testing
Copy link
Collaborator Author

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-no_rbac-no_auth.sh 1e934ea link /test e2e-suite-no_rbac-no_auth
prow/e2e-suite-rbac-auth.sh 1e934ea link /test e2e-suite-rbac-auth
prow/e2e-suite-rbac-no_auth.sh 1e934ea link /test e2e-suite-rbac-no_auth
prow/e2e-suite-no_rbac-auth.sh 1e934ea link /test e2e-suite-no_rbac-auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing deleted the autoUpdateDeps_766d651341c34f59ad0e63e225d087dc branch September 5, 2017 20:43
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* Restart sidecar proxy when Istio auth secret is changed

* Code refactor

* Check returned error

* return

* hash error

* move things into auth.go

* Watch certs in Egress

* Watch certs from Ingress

* renmae from auth.go to cert.go

* Add unit test for cert watcher

* test hashing

* check returned error

* address comments
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants